Added support for proxy envs in litmus chart
#390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonsy13 <[email protected]>
Jonsy13
requested review from
imrajdas,
ispeakc0de,
Jasstkn and
Saranya-jena
as code owners
Signed-off-by: Jonsy13 <[email protected]>
Saranya-jena
approved these changes
Jul 16, 2024
shovanmaity
reviewed
Jul 16, 2024
| @@ -153,6 +153,14 @@ spec: | |||
| value: "{{ (index .Values.portal.server.graphqlServer.ports 1).containerPort }}" | |||
| - name: ALLOWED_ORIGINS | |||
| value: "{{ .Values.allowedOrigins }}" | |||
| {{- if has "gql-server" .Values.proxy.components }} | |||
| - name: HTTP_PROXY | |||
There was a problem hiding this comment.
which apis calls or url will use this proxy variables?
There was a problem hiding this comment.
Users can use this incase of air-gapped setup where they can provide access to external resources like github or to an external cluster using proxy only.
shovanmaity
approved these changes
Jul 16, 2024
|
need this |
|
What is needed to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]